Skip to content

[stable32]: perf: Don't fetch all the trash items when deleting a single item#62178

Closed
CarlSchwan wants to merge 6 commits into
stable32from
carl/stable32/trashitem-delete-optimization
Closed

[stable32]: perf: Don't fetch all the trash items when deleting a single item#62178
CarlSchwan wants to merge 6 commits into
stable32from
carl/stable32/trashitem-delete-optimization

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

Manual backport of #61906

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan added this to the Nextcloud 32.0.13 milestone Jul 15, 2026
@CarlSchwan CarlSchwan self-assigned this Jul 15, 2026
@CarlSchwan
CarlSchwan requested a review from a team as a code owner July 15, 2026 12:59
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Jul 15, 2026
@CarlSchwan
CarlSchwan requested review from Altahrim, icewind1991 and salmart-dev and removed request for a team July 15, 2026 12:59
@CarlSchwan
CarlSchwan requested a review from come-nc July 15, 2026 12:59
@CarlSchwan CarlSchwan changed the title Carl/stable32/trashitem delete optimization [stable32]: perf: Don't fetch all the trash items when deleting a single item#61906 Jul 15, 2026
@CarlSchwan CarlSchwan changed the title [stable32]: perf: Don't fetch all the trash items when deleting a single item#61906 [stable32]: perf: Don't fetch all the trash items when deleting a single item Jul 15, 2026

@cristianscheid cristianscheid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't build/psalm-baseline.xml missing some entires (comparing with original PR and stable33 backport)?

Comment thread apps/files_trashbin/lib/Trash/ITrashManager.php Outdated
@CarlSchwan
CarlSchwan force-pushed the carl/stable32/trashitem-delete-optimization branch from 91d7364 to 2d76e3c Compare July 15, 2026 13:31
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Only take one argument and instead call this with array map

Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan force-pushed the carl/stable32/trashitem-delete-optimization branch from 2d76e3c to 43438c1 Compare July 15, 2026 13:39
@CarlSchwan

Copy link
Copy Markdown
Member Author

Not needed on stable32 anymore

@CarlSchwan CarlSchwan closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants